linux-kernel - Re: linux-next: Tree for August 14 (sysfs/acpi errors)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48A64E63.4000208@linux.intel.com>
Date:	Sat, 16 Aug 2008 05:49:55 +0200
From:	Andi Kleen <ak@...ux.intel.com>
To:	Rusty Russell <rusty@...tcorp.com.au>
CC:	Kay Sievers <kay.sievers@...y.org>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	gregkh <greg@...ah.com>, linux-next@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>, linux-acpi@...r.kernel.org,
	Sam Ravnborg <sam@...nborg.org>
Subject: Re: linux-next: Tree for August 14 (sysfs/acpi errors)

Rusty Russell wrote:
> On Saturday 16 August 2008 12:57:57 Andi Kleen wrote:
>>>> Extract is:
>>>>
>>>> XXX adding modparam:'acpi.power_nocheck' 34 (ffffffff806a4cf0)
>>> ...
>>>
>>>> XXX adding modparam:'acpi.acpica_version' 45 (ffffffff806a4ea8)
>>> Two different "modules" use the same prefix, which does not work with
>>> the current logic, they need to live next to each other in the sequence
>>> of options.
>> Sequence of options being defined by link order?
> 
> Simplest fix is to shuffle Makefile.  But better is to create an acpi "module"
> so the namespacing just works, something like below.  Overriding MODULE_PREFIX
> only works for builtin code anyway.  (Which makes sense: moving a parameter
> from one module to another isn't a change we can cover up).

Can't say I like this. This is fragile. I can just this exploding the next time
again with some innocent change.

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/