linux-kernel - Re: [PATCH 2.6.27-rc3 19/28] mdb: adding notify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <39683.166.70.238.45.1218868398.squirrel@webmail.wolfmountaingroup.com>
Date:	Sat, 16 Aug 2008 00:33:18 -0600 (MDT)
From:	jmerkey@...fmountaingroup.com
To:	"Andi Kleen" <andi@...stfloor.org>
Cc:	jmerkey@...fmountaingroup.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2.6.27-rc3 19/28] mdb: adding notify_die handler for 
     keyboard debugger entry

> jmerkey@...fmountaingroup.com writes:
>
>> +#if defined(CONFIG_MDB) || defined(CONFIG_MDB_MODULE)
>> +	if (down && !rep && keycode == KEY_PAUSE)
>> +        {
>> +	   if (notify_die(DIE_KERNELDEBUG, NULL, get_irq_regs(),
>> +                          0, -1, SIGINT) == NOTIFY_STOP)
>> +	      return;
>> +	}
>> +#endif
>> +
>>  #ifdef CONFIG_MAGIC_SYSRQ	       /* Handle the SysRq Hack */
>>  	if (keycode == KEY_SYSRQ && (sysrq_down || (down == 1 && sysrq_alt)))
>> {
>>  		if (!sysrq_down) {
>
> A nicer alternative to adding an hook here would be to use
> register_sysrq_key() to register a sysrq key that triggers
> the debugger.  That function is also already exported.
>
> -Andi
>

Got it.  Added to the list.  I will Instrument it.

Jeff

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/