linux-kernel - Re: [PATCH 3/5] ide: add a driver-wide debugging macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1218996786.24527.115.camel@localhost>
Date:	Sun, 17 Aug 2008 11:13:06 -0700
From:	Joe Perches <joe@...ches.com>
To:	Borislav Petkov <petkovbb@...glemail.com>
Cc:	Bartlomiej@...lum.tnic, Zolnierkiewicz@...lum.tnic,
	bzolnier@...il.com, linux-kernel@...r.kernel.org,
	linux-ide@...r.kernel.org, Borislav Petkov <petkovbb@...il.com>
Subject: Re: [PATCH 3/5] ide: add a driver-wide debugging macro

On Sun, 2008-08-17 at 19:23 +0200, Borislav Petkov wrote:
> diff --git a/include/linux/ide.h b/include/linux/ide.h
> index c161840..b6d714d 100644
> --- a/include/linux/ide.h
> +++ b/include/linux/ide.h
> []
> +/* DRV_NAME has to be defined in the driver before using the macro below */
> +#define __ide_debug_log(lvl, fmt, args...)			\
> +{								\
> +	if (unlikely(drive->debug_mask & lvl))			\
> +		printk(KERN_INFO DRV_NAME ": " fmt, ## args);	\
> +}

Shouldn't a debug printk use KERN_DEBUG?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/