linux-kernel - [PATCH 0/15] apic: unification series 5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1219077963-22883-1-git-send-email-gorcunov@gmail.com>
Date:	Mon, 18 Aug 2008 20:45:48 +0400
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	mingo@...e.hu, macro@...ux-mips.org
Cc:	hpa@...or.com, tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: [PATCH 0/15] apic: unification series 5

This series is over

commit d5e629a6f88137fb77c4cc857be5ea7c3f27110d
Author: Yinghai Lu <yhlu.kernel@...il.com>
Date:   Sun Aug 17 21:12:27 2008 -0700

    x86: apic - unify lapic_resume - fix

    Signed-off-by: Yinghai Lu <yhlu.kernel@...il.com>
    Signed-off-by: Ingo Molnar <mingo@...e.hu>

Please review - any comments are quite welcome!

Mostly #ifdef added, code rearrangement - nothing serious
(except new bugs have been brought in :-)

So I think the most simple/basic unification is done.
Now unif. process will be harder since it will require
for much detailed code review - for example smp_spurious_interrupt
which uses different call frames on 32/64 bit modes and will
require some wrapping I think.

With this series 32bit code compilation warns:

arch/x86/kernel/apic_32.c: In function ‘end_local_APIC_setup’:
arch/x86/kernel/apic_32.c:1165: warning: ISO C90 forbids mixed declarations and code
arch/x86/kernel/apic_32.c: In function ‘disconnect_bsp_APIC’:
arch/x86/kernel/apic_32.c:1446: warning: ISO C90 forbids mixed declarations and code
cyrill@...ovo linux-2.6.git $ 

So parenthesis will be needed to eliminate them... but
I think it could be too ugly... need some time to think.
So patches 8/15 and 10/15 sould be not applied for now - just review them.
Thanks for patience!

		- Cyrill -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/