| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20080818172830.GC7237@lenovo> Date: Mon, 18 Aug 2008 21:28:30 +0400 From: Cyrill Gorcunov <gorcunov@...il.com> To: "H. Peter Anvin" <hpa@...or.com> Cc: mingo@...e.hu, macro@...ux-mips.org, tglx@...utronix.de, linux-kernel@...r.kernel.org Subject: Re: [PATCH 0/15] apic: unification series 5 [H. Peter Anvin - Mon, Aug 18, 2008 at 10:22:12AM -0700] > Cyrill Gorcunov wrote: >> >> With this series 32bit code compilation warns: >> >> arch/x86/kernel/apic_32.c: In function ‘end_local_APIC_setup’: >> arch/x86/kernel/apic_32.c:1165: warning: ISO C90 forbids mixed declarations and code >> arch/x86/kernel/apic_32.c: In function ‘disconnect_bsp_APIC’: >> arch/x86/kernel/apic_32.c:1446: warning: ISO C90 forbids mixed declarations and code >> cyrill@...ovo linux-2.6.git $ >> >> So parenthesis will be needed to eliminate them... but >> I think it could be too ugly... need some time to think. >> So patches 8/15 and 10/15 sould be not applied for now - just review them. >> Thanks for patience! >> > > Typically, just move the declaration to the top of the function > (followed by a blank line.) > > -hpa > well in case of the patch 10/15 it's not good since I don't want to waste even 4 bytes in stack for 64bit APIC :) I guess gcc could find it and just eliminate - will take a look. - Cyrill - -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists