[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080818034851.GB30843@kroah.com>
Date: Sun, 17 Aug 2008 20:48:51 -0700
From: Greg KH <greg@...ah.com>
To: Andi Kleen <andi@...stfloor.org>
Cc: Kay Sievers <kay.sievers@...y.org>,
Randy Dunlap <randy.dunlap@...cle.com>,
Stephen Rothwell <sfr@...b.auug.org.au>,
linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
linux-acpi@...r.kernel.org, rusty@...tcorp.com.au
Subject: Re: linux-next: Tree for August 14 (sysfs/acpi errors)
On Sun, Aug 17, 2008 at 05:53:07AM +0200, Andi Kleen wrote:
> Greg KH <greg@...ah.com> writes:
> >> No!
> >
> > What you are doing here is wrong, trying to create two files with the
> > same name. You just should not be doing that at all, it's that simple.
> > Fix the broken code/link order, don't paper it over in the sysfs layer.
>
> Sorry, but relying on link order for anything is a mistake. It is subtle
> and fragile and just means it'll eventually break again because it's
> near impossible to properly maintain.
We rely on link order for all sorts of things, this isn't new at all.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists