linux-kernel - Re: [PATCH 2/2] acpi_pm.c: check for monotonicity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080818201844.GA3506@rhlx01.hs-esslingen.de>
Date:	Mon, 18 Aug 2008 22:18:44 +0200
From:	Andreas Mohr <andi@...as.de>
To:	Dominik Brodowski <linux@...inikbrodowski.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andreas Mohr <andi@...as.de>, linux-kernel@...r.kernel.org,
	linux-acpi@...r.kernel.org, johnstul@...ibm.com,
	hirofumi@...l.parknet.co.jp, alan@...rguk.ukuu.org.uk,
	arjan@...radead.org
Subject: Re: [PATCH 2/2] acpi_pm.c: check for monotonicity

Hi,

On Mon, Aug 18, 2008 at 10:11:15PM +0200, Dominik Brodowski wrote:
> +	if (good != 10) {
> +		printk(KERN_INFO "PM-Timer had no reasonable result:"
> +		       " 0x%#llx - aborting.\n", value1);
> +		return -ENODEV;
>  	}
> -	printk(KERN_INFO "PM-Timer had no reasonable result:"
> -			" 0x%#llx - aborting.\n", value1);
> -	return -ENODEV;

Technically spoken this log message could now be considered partially
outdated... (we're doing 10 evaluations after all, not one with a
precise end result).


Seeing a define for those several open-coded 10 loops values would be nice.

Andreas Mohr
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/