linux-kernel - Re: [PATCH] POWERPC: duplicate test of MACIO_FLAG_SCCB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1219095733.28339.77.camel@pasglop>
Date:	Tue, 19 Aug 2008 07:42:13 +1000
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	roel kluin <roel.kluin@...il.com>
Cc:	paulus@...ba.org, linuxppc-dev@...abs.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] POWERPC: duplicate test of MACIO_FLAG_SCCB_ON

On Mon, 2008-08-18 at 18:34 -0400, roel kluin wrote:
> untested, is it correct?

Your patch is correct. The bug is quite harmless thankfully :-)

Ben.
 
> arch/powerpc/include/asm/pmac_feature.h:359:
> #define MACIO_FLAG_SCCA_ON  0x00000001
> #define MACIO_FLAG_SCCB_ON  0x00000002
> ---
> duplicate test of MACIO_FLAG_SCCB_ON
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
> diff --git a/arch/powerpc/platforms/powermac/feature.c b/arch/powerpc/platforms/powermac/feature.c
> index 5169ecc..e6c0040 100644
> --- a/arch/powerpc/platforms/powermac/feature.c
> +++ b/arch/powerpc/platforms/powermac/feature.c
> @@ -2677,7 +2677,7 @@ static void __init probe_one_macio(const char *name, const char *compat, int typ
>  	macio_chips[i].of_node	= node;
>  	macio_chips[i].type	= type;
>  	macio_chips[i].base	= base;
> -	macio_chips[i].flags	= MACIO_FLAG_SCCB_ON | MACIO_FLAG_SCCB_ON;
> +	macio_chips[i].flags	= MACIO_FLAG_SCCA_ON | MACIO_FLAG_SCCB_ON;
>  	macio_chips[i].name	= macio_names[type];
>  	revp = of_get_property(node, "revision-id", NULL);
>  	if (revp)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/