linux-kernel - Re: [PATCH] net: forcedeth use pci_choose_state instead of PCI_D3hot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200808190008.54743.rjw@sisk.pl>
Date:	Tue, 19 Aug 2008 00:08:53 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	"Yinghai Lu" <yhlu.kernel@...il.com>
Cc:	"Jeff Garzik" <jgarzik@...hat.com>, "Ingo Molnar" <mingo@...e.hu>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, netdev <netdev@...r.kernel.org>,
	"Jesse Barnes" <jbarnes@...tuousgeek.org>,
	Simon Arlott <simon@...e.lp0.eu>
Subject: Re: [PATCH] net: forcedeth use pci_choose_state instead of PCI_D3hot - v2

On Monday, 18 of August 2008, Yinghai Lu wrote:
> On Mon, Aug 18, 2008 at 3:22 AM, Rafael J. Wysocki <rjw@...k.pl> wrote:
> 
> >> > >  drivers/net/forcedeth.c |    8 +++++---
> >> > >  1 file changed, 5 insertions(+), 3 deletions(-)
> >> > >
> >> > > Index: linux-2.6/drivers/net/forcedeth.c
> >> > > ===================================================================
> >> > > --- linux-2.6.orig/drivers/net/forcedeth.c
> >> > > +++ linux-2.6/drivers/net/forcedeth.c
> >> > > @@ -5975,10 +5975,12 @@ static void nv_shutdown(struct pci_dev *
> >> > >        if (netif_running(dev))
> >> > >                nv_close(dev);
> >> > >
> >> > > -       pci_enable_wake(pdev, PCI_D3hot, np->wolenabled);
> >> > > -       pci_enable_wake(pdev, PCI_D3cold, np->wolenabled);
> >> > >        pci_disable_device(pdev);
> >> > > -       pci_set_power_state(pdev, PCI_D3hot);
> >> > > +       if (system_state == SYSTEM_POWER_OFF) {
> >> > > +               if (pci_enable_wake(pdev, PCI_D3cold, np->wolenabled))
> >> > > +                       pci_enable_wake(pdev, PCI_D3hot, np->wolenabled);
> >> > > +               pci_set_power_state(pdev, PCI_D3hot);
> >> > > +       }
> >> > >  }
> >> > >  #else
> >> > >  #define nv_suspend NULL
> >> > >
> >> >
> 
> > Does the last patch work for you BTW?
> >
> 
> it works.

OK, thanks for testing.

I think we can use it as a quick fix for 2.6.27.  Do you agree?

Still, it would be helpful to verify if this is the same MSI issue reported by
Simon.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/