linux-kernel - Re: [PATCH] audit: Moved variable declaration to beginning of function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LRH.1.10.0808190822350.24485@tundra.namei.org>
Date:	Tue, 19 Aug 2008 08:23:12 +1000 (EST)
From:	James Morris <jmorris@...ei.org>
To:	Cordelia <cordsam@...ux.vnet.ibm.com>
cc:	linux-kernel@...r.kernel.org, Al Viro <viro@....linux.org.uk>
Subject: Re: [PATCH] audit: Moved variable declaration to beginning of
 function

On Mon, 18 Aug 2008, Cordelia wrote:

> got rid of compilation warning:
> ISO C90 forbids mixed declarations and code
> 
> Signed-off-by: Cordelia Sam <cordesam@...il.com>
> ---
>  kernel/auditsc.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/auditsc.c b/kernel/auditsc.c
> index 972f8e6..59cedfb 100644
> --- a/kernel/auditsc.c
> +++ b/kernel/auditsc.c
> @@ -243,10 +243,11 @@ static inline int open_arg(int flags, int mask)
>  
>  static int audit_match_perm(struct audit_context *ctx, int mask)
>  {
> +	unsigned n;
>  	if (unlikely(!ctx))
>  		return 0;
>  
> -	unsigned n = ctx->major;
> +	n = ctx->major;
>  	switch (audit_classify_syscall(ctx->arch, n)) {
>  	case 0:	/* native */
>  		if ((mask & AUDIT_PERM_WRITE) &&


Reviewed-by: James Morris <jmorris@...ei.org>

-- 
James Morris
<jmorris@...ei.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/