linux-kernel - Re: [PATCH] Fix i486 suspend to disk CR4 oops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080818064240.GC9807@one.firstfloor.org>
Date:	Mon, 18 Aug 2008 08:42:40 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Andi Kleen <andi@...stfloor.org>,
	"Maciej W. Rozycki" <macro@...ux-mips.org>,
	David Fries <david@...es.net>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix i486 suspend to disk CR4 oops

On Sun, Aug 17, 2008 at 11:34:50PM -0700, H. Peter Anvin wrote:
> Andi Kleen wrote:
> >>>
> >>The other alternative is to probe for the CPUID instruction (via
> >>EFLAGS.ID) -- CR4 is present if and only if CPUID exists.
> >
> >Can be already checked for with boot_cpu_data.extended_cpuid_level.
> >
> 
> I believe you mean just plain cpuid_level (which is set to -1 if CPUID 
> doesn't exist.)  extended_cpuid_level is only defined on x86-64, but all 
> x86-64 CPUs have CR4.

Yes I meant plain cpuid_level. Just wanted to mention that before someone
opencodes another cpuid test.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/