linux-kernel - Re: [PATCH 0/15] apic: unification series 5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 19 Aug 2008 02:09:10 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Cyrill Gorcunov <gorcunov@...il.com>
Cc:	"H. Peter Anvin" <hpa@...or.com>, macro@...ux-mips.org,
	tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/15] apic: unification series 5


* Cyrill Gorcunov <gorcunov@...il.com> wrote:

> [H. Peter Anvin - Mon, Aug 18, 2008 at 10:22:12AM -0700]
> > Cyrill Gorcunov wrote:
> >>
> >> With this series 32bit code compilation warns:
> >>
> >> arch/x86/kernel/apic_32.c: In function ‘end_local_APIC_setup’:
> >> arch/x86/kernel/apic_32.c:1165: warning: ISO C90 forbids mixed declarations and code
> >> arch/x86/kernel/apic_32.c: In function ‘disconnect_bsp_APIC’:
> >> arch/x86/kernel/apic_32.c:1446: warning: ISO C90 forbids mixed declarations and code
> >> cyrill@...ovo linux-2.6.git $ 
> >>
> >> So parenthesis will be needed to eliminate them... but
> >> I think it could be too ugly... need some time to think.
> >> So patches 8/15 and 10/15 sould be not applied for now - just review them.
> >> Thanks for patience!
> >>
> >
> > Typically, just move the declaration to the top of the function  
> > (followed by a blank line.)
> >
> > 	-hpa
> >
> Here is compilation warnings fix

applied the 15 patches and this fixlet to tip/x86/apic - thanks Cyrill.

> Please check if it's not worse code form now :)

> +	{
> +		unsigned int value;
> +		/* Disable the local apic timer */
> +		value = apic_read(APIC_LVTT);
> +		value |= (APIC_LVT_MASKED | LOCAL_TIMER_VECTOR);
> +		apic_write(APIC_LVTT, value);
> +	}

that's OK.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/