linux-kernel - Re: oprofile + hibernation = badness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48AAB8B6.3020802@linux.intel.com>
Date:	Tue, 19 Aug 2008 14:12:38 +0200
From:	Andi Kleen <ak@...ux.intel.com>
To:	Ingo Molnar <mingo@...e.hu>
CC:	Vegard Nossum <vegard.nossum@...il.com>,
	Pavel Machek <pavel@...e.cz>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Robert Richter <robert.richter@....com>,
	Philippe Elie <phil.el@...adoo.fr>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: oprofile + hibernation = badness

Ingo Molnar wrote:
> * Vegard Nossum <vegard.nossum@...il.com> wrote:
> 
>> This gets rid of the suspend warnings, so it looks to be a step in the 
>> right direction! FWIW, you may add my Tested-by to the patch.
> 
> i've queued it up in tip/x86/oprofile - thanks guys.

I would have thought Robert would take them? He's oprofile
maintainer after all.

> 
> Andi, another issue: your patch had 5 spurious whitespace errors. This 
> is a reoccuring, many years pattern of behavior from you and you need to 
> fix your workflow to send less sloppy patches. 

Yes I forgot you define patch cleanness based on white space.

Seriously, It's actually new -- i did this one in git directly instead of
quilt and git-commit doesn't seem to know how to drop them. In my older quilt
workflow they were always automatically dropped since many years. Both emacs
and vim add them and I don't plan to switch editors, sorry.

> I fixed up the problems of this patch, no need to resend.

I hope you fixed the typos in the commit log too (it really was just
a RFC test patch)

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/