linux-kernel - Re: [PATCH] powerpc, scc: duplicate SCC_UHC_USBCEN

Open Source and information security mailing list archives

Message-Id: <20080819.220200.-1300539182.kouish@swc.toshiba.co.jp>
Date:	Tue, 19 Aug 2008 22:02:00 +0900 (JST)
From:	Kou Ishizaki <kou.ishizaki@...hiba.co.jp>
To:	roel.kluin@...il.com
Cc:	paulus@...ba.org, benh@...nel.crashing.org,
	linuxppc-dev@...abs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] powerpc, scc: duplicate SCC_UHC_USBCEN

Roel,

> untested, is it correct?

Your patch is correct.

Thanks for your pointing it out and sending the patch. I tested your
patch and it works good.

Fortunately, this bug is not fatal because it seems that the SCC-UHC
sets SCC_UHC_USBEN and SCC_UHC_USBCEN at once.

Your patch does not contain 'Signed-off-by' line. Could you re-post it
with your sign?

> ---
> arch/powerpc/platforms/cell/celleb_scc.h:224:
> #define SCC_UHC_USBEN           0x00010000
> #define SCC_UHC_USBCEN          0x00020000
> 
> ---
> diff --git a/arch/powerpc/platforms/cell/celleb_scc_uhc.c b/arch/powerpc/platforms/cell/celleb_scc_uhc.c
> index d63b720..b086f33 100644
> --- a/arch/powerpc/platforms/cell/celleb_scc_uhc.c
> +++ b/arch/powerpc/platforms/cell/celleb_scc_uhc.c
> @@ -31,7 +31,7 @@
>  
>  static inline int uhc_clkctrl_ready(u32 val)
>  {
> -	const u32 mask = SCC_UHC_USBCEN | SCC_UHC_USBCEN;
> +	const u32 mask = SCC_UHC_USBCEN | SCC_UHC_USBEN;
>  	return((val & mask) == mask);
>  }
>  
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@...abs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev

Best regards,
Kou Ishizaki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives