linux-kernel - Re: [PATCH] X86: Change the default value of nr_irqs from 32 to NR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 19 Aug 2008 10:44:43 -0700
From:	"Yinghai Lu" <yhlu.kernel@...il.com>
To:	"Alex Nixon" <alex.nixon@...rix.com>
Cc:	"Ingo Molnar" <mingo@...e.hu>,
	"Jeremy Fitzhardinge" <Jeremy.Fitzhardinge@...rix.com>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] X86: Change the default value of nr_irqs from 32 to NR_IRQs

On Tue, Aug 19, 2008 at 9:55 AM, Alex Nixon <alex.nixon@...rix.com> wrote:
> From: Alex Nixon <alex.nixon@...rix.com>
> Date: Tue, 19 Aug 2008 17:49:37 +0100
> Subject: [PATCH] X86:  Change the default value of nr_irqs from 32 to NR_IRQs
>
> If the number of discovered IRQs is suspiciously low, this patch causes the number reported to default to NR_IRQS, rather than 32.  NR_IRQS has already been defined to be a sensible value for the current system (in particular, at least 224 when paravirtualisation is involved).
>
> Signed-off-by: Alex Nixon <alex.nixon@...rix.com>
> ---
>  arch/x86/kernel/io_apic.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kernel/io_apic.c b/arch/x86/kernel/io_apic.c
> index 30ff794..11bffa1 100644
> --- a/arch/x86/kernel/io_apic.c
> +++ b/arch/x86/kernel/io_apic.c
> @@ -3632,7 +3632,7 @@ int __init probe_nr_irqs(void)
>
>        /* something wrong ? */
>        if (nr < 32)
> -               nr = 32;
> +               nr = NR_IRQS;
>
>        return nr;
>  }
> --
if only one ioapic, nr will be 24<<1, you will get 48. Does pv has io apic ?

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/