[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20080819011656.GC14821@elte.hu>
Date: Tue, 19 Aug 2008 03:16:56 +0200
From: Ingo Molnar <mingo@...e.hu>
To: Yinghai Lu <yhlu.kernel@...il.com>
Cc: Thomas Gleixner <tglx@...utronix.de>,
"H. Peter Anvin" <hpa@...or.com>,
Andrew Morton <akpm@...ux-foundation.org>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irq: rename irq_desc() to to_irq_desc() - fix #3
* Yinghai Lu <yhlu.kernel@...il.com> wrote:
> > - kstat_this_cpu.irqs[irq]++;
> > + kstat_irqs_this_cpu(&irq_desc[irq])++;
> >
> > out:
> > unspinning_lock(xl);
> >
>
> should be
>
> kstat_irqs_this_cpu(to_irq_desc(irq))++;
>
> otherwise when CONFIG_HAVE_SPARSE_IRQ is set, it will fail.
>
> when sparse_irq is set, only have irq_descX list...
ok, fixed it - updated patch below. Build testing just triggered it as
well.
Ingo
----------->
>From ba0540e8ae86abbe55b643e230ce276984fbb650 Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@...e.hu>
Date: Tue, 19 Aug 2008 02:33:39 +0200
Subject: [PATCH] irq: build fix
fix:
arch/x86/xen/spinlock.c: In function 'xen_spin_lock_slow':
arch/x86/xen/spinlock.c:90: error: 'struct kernel_stat' has no member named 'irqs'
Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
arch/x86/xen/spinlock.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/xen/spinlock.c b/arch/x86/xen/spinlock.c
index 8dc4d31..bfb1707 100644
--- a/arch/x86/xen/spinlock.c
+++ b/arch/x86/xen/spinlock.c
@@ -87,7 +87,7 @@ static noinline int xen_spin_lock_slow(struct raw_spinlock *lock)
/* block until irq becomes pending */
xen_poll_irq(irq);
- kstat_this_cpu.irqs[irq]++;
+ kstat_irqs_this_cpu(to_irq_desc(irq))++;
out:
unspinning_lock(xl);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists