linux-kernel - Re: [PATCH 1/2] rtc: rtc-ds1374: fix 'no irq' case handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080819212937.01dfd024@lxorguk.ukuu.org.uk>
Date:	Tue, 19 Aug 2008 21:29:37 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	"Jon Smirl" <jonsmirl@...il.com>
Cc:	"Anton Vorontsov" <avorontsov@...mvista.com>,
	"Alessandro Zummo" <a.zummo@...ertech.it>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	linuxppc-dev@...abs.org, linux-kernel@...r.kernel.org,
	rtc-linux@...glegroups.com
Subject: Re: [PATCH 1/2] rtc: rtc-ds1374: fix 'no irq' case handling

> Shouldn't this be
> 
> >  -       if (client->irq <= NO_IRQ)
> 
> instead of

NO_IRQ is obsolete. client->irq != is the test and IRQ numbers are
unsigned.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/