linux-kernel - Re: [PATCH 08/10] PPS: serial clients support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080819225659.3060a49f@lxorguk.ukuu.org.uk>
Date:	Tue, 19 Aug 2008 22:56:59 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Rodolfo Giometti <giometti@...ux.it>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Woodhouse <dwmw2@...radead.org>,
	Dave Jones <davej@...hat.com>, Sam Ravnborg <sam@...nborg.org>,
	Greg KH <greg@...ah.com>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Kay Sievers <kay.sievers@...y.org>,
	Rodolfo Giometti <giometti@...ux.it>
Subject: Re: [PATCH 08/10] PPS: serial clients support.

> +static void pps_tty_dcd_change(struct uart_port *port, unsigned int status,
> +				struct timespec *ts)
> +{
> +	int id = (int) port->info->port.tty->disc_data;

See you really do want to pass struct tty * upwards anyway 8)


Rest of this looks good. Maybe pps ldisc belongs in the n_tty file in the
end but again that can be twiddled with after the merge.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/