linux-kernel - Re: [PATCH] CRED: Take cred_exec_mutex in compat_do_execve() and fix error handling in do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.1.10.0808200910020.317@tundra.namei.org>
Date:	Wed, 20 Aug 2008 09:29:50 +1000 (EST)
From:	James Morris <jmorris@...ei.org>
To:	David Howells <dhowells@...hat.com>
cc:	a.beregalov@...il.com, linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org,
	Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH] CRED: Take cred_exec_mutex in compat_do_execve() and
 fix error handling in do_execve()

On Tue, 19 Aug 2008, David Howells wrote:

> Take cred_exec_mutex in compat_do_execve().  This reflects what do_execve()
> does.  The mutex protects credentials calculation against PTRACE_ATTACH needing
> to alter it mid-exec.
> 
> Also fix the error handling in do_execve().  The mutex needs to be unlocked if
> an error occurs after it is taken, but before the install_exec_creds()
> released it.
> 
> Signed-off-by: David Howells <dhowells@...hat.com>

Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next-creds

Hopefully this will be in the next linux-next tree for testing.

Alexander, please let us know if it fixes the problem you saw.


- James
-- 
James Morris
<jmorris@...ei.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/