linux-kernel - Re: vfat BKL/lock_super regression in v2.6.26-rc3-g8f59342

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.10.0808191748040.3324@nehalem.linux-foundation.org>
Date:	Tue, 19 Aug 2008 17:56:10 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Bart Trojanowski <bart@...ie.net>
cc:	linux-kernel@...r.kernel.org, Al Viro <viro@...iv.linux.org.uk>
Subject: Re: vfat BKL/lock_super regression in v2.6.26-rc3-g8f59342

On Tue, 19 Aug 2008, Linus Torvalds wrote:
> 
> But I don't know exactly what the timeout should be, though (although I 
> suspect that it should involve _ignoring_ non-data writes like the atime 
> updates, and trigger a timeout on data writes so that when you actually 
> write a file, you'll know that the sync will happen within five seconds of 
> you having finished the write or whatever).

.. and by "finished the write" I mean "closed the file", not "end of 
write() system call". Ie it's one of those things where it really doesn't 
mostly make much sense to try to give any kinds of flush guarantees until 
the user has basically shown that he's all done with writing.

If you have something like removable media, and you actually remove it 
while you have a "cp -R" in progress, it damn well won't matter whether we 
were synchronous or not. But if you remove it after the "cp" has actually 
finished, it's a lot more understandable if somebody expects it to be on 
disk.

So one thing we could perhaps consider is to make FAT in particular 
consider "sync" mounts to be about open/close consistency, not about 
per-write-system-call consistency. So the "close()" wouldn't return until 
the file is on disk, but we wouldn't force a synchronous rewrite the inode 
or the file allocation table thousands of times just because the file was 
big.

FAT really is kind of different. I suspect we could just change what 
"sync" means for it. But it would probably be good to have a VFS-level 
notion of open-close consistency. It is, after all, what NFS is already 
supposed to give you, so there is precedence for that being a useful IO 
serialization model.

Al, what do you think?

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/