linux-kernel - Re: [PATCH 05/10] ldisc: new dcd_change() method for line disciplines.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080820134849.GB20648@elte.hu>
Date:	Wed, 20 Aug 2008 15:48:49 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Rodolfo Giometti <giometti@...eenne.com>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Woodhouse <dwmw2@...radead.org>,
	Dave Jones <davej@...hat.com>, Sam Ravnborg <sam@...nborg.org>,
	Greg KH <greg@...ah.com>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Kay Sievers <kay.sievers@...y.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH 05/10] ldisc: new dcd_change() method for line
	disciplines.


* Rodolfo Giometti <giometti@...eenne.com> wrote:

> On Wed, Aug 20, 2008 at 11:11:17AM +0100, Alan Cox wrote:
> 
> > Can we get the basics right first - drop the IRQ_EVENTS and HARDPPS
> > hackery out of the patchset and the core code then looks quite clean.
> > After that is sorted/merged we can come back to working out the best way
> > to improve the IRQ and HARDPPS hacks.
> 
> On Wed, Aug 20, 2008 at 12:31:15PM +0200, Ingo Molnar wrote:
> 
> > hm, NACK on this line of approach. If then this instrumentation should 
> > be done at the genirq level (kernel/irq/*.c). Also, the #ifdefs are ugly 
> > - please hide them in include files.
> 
> Ok, I'll propose a new patch set without the IRQ_EVENTS part (or with 
> this support as last patch to be easily discarted) to get kernel 
> inclusion, but we had to solve this issue soon since without this 
> trick the PPS precision is quite low.

well, i didnt suggest you kill that aspect of the patchset - i suggested 
you change it to hook into kernel/irq/*.c instead of 
arch/x86/kernel/irq*.c.

That way all other architectures will benefit from it, not just x86. 
Doing an x86-only thing for such features is completely unacceptable.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/