linux-kernel - Re: [PATCH] kernel/module: fix warning when !CONFIG_DYNAMIC_PRINTK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 20 Aug 2008 07:24:53 -0700
From:	Greg KH <gregkh@...e.de>
To:	Alexander Beregalov <a.beregalov@...il.com>
Cc:	jbaron@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel/module: fix warning when
	!CONFIG_DYNAMIC_PRINTK_DEBUG

On Wed, Aug 20, 2008 at 06:13:29PM +0400, Alexander Beregalov wrote:
> From: Alexander Beregalov <a.beregalov@...il.com>
> 
> kernel/module.c: In function 'load_module':
> kernel/module.c:1839: warning: unused variable 'value'
> kernel/module.c:1838: warning: unused variable 'iter'
> 
> 
> Signed-off-by: Alexander Beregalov <a.beregalov@...il.com>
> ---
> 
>  kernel/module.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/kernel/module.c b/kernel/module.c
> index 1721320..5a1258e 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -1835,8 +1835,10 @@ static struct module *load_module(void __user *umod,
>  	unsigned int markersindex;
>  	unsigned int markersstringsindex;
>  	unsigned int verboseindex;
> +#ifdef CONFIG_DYNAMIC_PRINTK_DEBUG
>  	struct mod_debug *iter;
>  	unsigned long value;
> +#endif

Hm, that's not very nice, we try to keep #ifdefs out of the .c file
where ever possible, especially within a single function.  I'll split
the section out of this function that has the #ifdef which should fix
this problem.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/