linux-kernel - Re: [PATCH 1/1] toshiba_acpi: Add support for bluetooth toggling through rfkill (v6)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200808201757.04501.IvDoorn@gmail.com>
Date:	Wed, 20 Aug 2008 17:57:04 +0200
From:	Ivo van Doorn <ivdoorn@...il.com>
To:	Philip Langdale <philipl@...rt.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Henrique de Moraes Holschuh <hmh@....eng.br>,
	Matthew Garrett <mjg59@...f.ucam.org>,
	toshiba_acpi@...ebeam.org, linux-wireless@...r.kernel.org
Subject: Re: [PATCH 1/1] toshiba_acpi: Add support for bluetooth toggling through rfkill (v6)

Hi,

> +	if (unlikely(state_changed)) {
> +		rfkill_force_state(dev->rfk_dev,
> +				   new_rfk_state ?
> +				   RFKILL_STATE_SOFT_BLOCKED :
> +				   RFKILL_STATE_HARD_BLOCKED);
> +		input_report_switch(poll_dev->input, SW_RFKILL_ALL, new_rfk_state);
> +	}
> +}

This looks very nice, but is the switch really toggling between
soft and hard blocked only? ;)

I mean shouldn't there be some unblock signal at some point?

Ivo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/