linux-kernel - Re: [PATCH] fbdefio: add set_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1219261254.3996.54.camel@localhost.localdomain>
Date:	Wed, 20 Aug 2008 20:40:54 +0100
From:	Ian Campbell <ijc@...lion.org.uk>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
	stable@...nel.org, jayakumar.lkml@...il.com, npiggin@...e.de,
	a.p.zijlstra@...llo.nl, hugh@...itas.com, hannes@...urebad.de,
	jeremy@...p.org, kel@...ku42.de, armbru@...hat.com
Subject: Re: [PATCH] fbdefio: add set_page_dirty handler to deferred IO FB

On Wed, 2008-08-20 at 12:30 -0700, Andrew Morton wrote:
> On Wed, 20 Aug 2008 19:57:53 +0100 Ian Campbell <ijc@...lion.org.uk>
> wrote:
>  	}
> > +#ifdef CONFIG_FB_DEFERRED_IO
> > +	if (info->fbdefio)
> > +		fb_deferred_io_open(info, inode, file);
> > +#endif
> 
> eww, hacky, but drivers/video/fbmem.c already got hacky:
> 
> #ifdef CONFIG_FB_DEFERRED_IO
>         .fsync =        fb_deferred_io_fsync,
> #endif
> 
> so it's not an original sin.

That's what I figured.

> Does it work?

Yep.

Ian.
-- 
Ian Campbell

Nobody knows what goes between his cold toes and his warm ears.
		-- Roy Harper

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)