linux-kernel - Re: [PATCH] fbdefio: add set_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <45a44e480808201611h57185209q9d738db054c3363b@mail.gmail.com>
Date:	Wed, 20 Aug 2008 19:11:34 -0400
From:	"Jaya Kumar" <jayakumar.lkml@...il.com>
To:	"Andrew Morton" <akpm@...ux-foundation.org>
Cc:	"Ian Campbell" <ijc@...lion.org.uk>, torvalds@...ux-foundation.org,
	linux-kernel@...r.kernel.org, stable@...nel.org, npiggin@...e.de,
	a.p.zijlstra@...llo.nl, hugh@...itas.com, hannes@...urebad.de,
	jeremy@...p.org, kel@...ku42.de, armbru@...hat.com
Subject: Re: [PATCH] fbdefio: add set_page_dirty handler to deferred IO FB

On Wed, Aug 20, 2008 at 3:50 PM, Andrew Morton
<akpm@...ux-foundation.org> wrote:
> On Wed, 20 Aug 2008 20:40:54 +0100
> Ian Campbell <ijc@...lion.org.uk> wrote:
>
>> On Wed, 2008-08-20 at 12:30 -0700, Andrew Morton wrote:
>> > On Wed, 20 Aug 2008 19:57:53 +0100 Ian Campbell <ijc@...lion.org.uk>
>> > wrote:
>> >     }
>> > > +#ifdef CONFIG_FB_DEFERRED_IO
>> > > + if (info->fbdefio)
>> > > +         fb_deferred_io_open(info, inode, file);
>> > > +#endif
>> >
>> > eww, hacky, but drivers/video/fbmem.c already got hacky:
>> >
>> > #ifdef CONFIG_FB_DEFERRED_IO
>> >         .fsync =        fb_deferred_io_fsync,
>> > #endif
>> >
>> > so it's not an original sin.
>>
>> That's what I figured.
>
> A better implementation would be to change the fb_ops.fb_open()
> arguments, or to add fb_ops.fb_open2() with the file*.
>
> Also, that .fsync thing should be done properly via a new fb_ops.fb_fsync().
>
> But neither are pressing issues and I guess can be left for when Jaya
> is feeling bored?


hehe, i haven't bene bored ever since i started playing with linux. :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/