linux-kernel - Re: [PATCH 1/1] toshiba_acpi: Add support for bluetooth toggling through rfkill (v5)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48AB8941.4080209@overt.org>
Date:	Tue, 19 Aug 2008 20:02:25 -0700
From:	Philip Langdale <philipl@...rt.org>
To:	Henrique de Moraes Holschuh <hmh@....eng.br>
CC:	LKML <linux-kernel@...r.kernel.org>,
	Matthew Garrett <mjg59@...f.ucam.org>,
	toshiba_acpi@...ebeam.org, Ivo van Doorn <ivdoorn@...il.com>,
	linux-wireless@...r.kernel.org
Subject: Re: [PATCH 1/1] toshiba_acpi: Add support for bluetooth toggling
 through rfkill (v5)

Henrique de Moraes Holschuh wrote:
>> +		toshiba_acpi.rfk_dev->state = RFKILL_STATE_OFF;
> 
> Where did that RFKILL_STATE_OFF came from ? :-)  Just get rid of it, you
> override it four statements later anyway...

Left over from the first iteration. Now removed and diff updated.

> 
> Other than that, the rfkill bits look fine to me.
> 

Thanks. Anyone else care to voice an opinion? Should this go in through
wireless-testing then?

--phil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/