linux-kernel - Re: [PATCH] x86: silence section mismatch warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080821103444.GE19452@elte.hu>
Date:	Thu, 21 Aug 2008 12:34:44 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Marcin Slusarz <marcin.slusarz@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, Jack Steiner <steiner@....com>
Subject: Re: [PATCH] x86: silence section mismatch warning - uv_cpu_init


* Marcin Slusarz <marcin.slusarz@...il.com> wrote:

> WARNING: vmlinux.o(.cpuinit.text+0x3cc4): Section mismatch in reference from the function uv_cpu_init() to the function .init.text:uv_system_init()
> The function __cpuinit uv_cpu_init() references
> a function __init uv_system_init().
> If uv_system_init is only used by uv_cpu_init then
> annotate uv_system_init with a matching annotation.
> 
> uv_system_init was ment to be called only once, so make explicit by 
> creating properly-named function and annotate it as __ref.
> 
> Old code relied on uv_node_to_blade being initialized to 0, but it'a 
> not initialized from anywhere and it's not static either.

this needs a proper fix as the patch is too ugly. If something should be 
called only once then it has to go into a codepath that will only 
initialize it once.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/