linux-kernel - Re: [PATCH] sched: properly account IRQ and RT load in SCHED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080821104718.GA28331@elte.hu>
Date:	Thu, 21 Aug 2008 12:47:18 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Nick Piggin <nickpiggin@...oo.com.au>,
	Gregory Haskins <ghaskins@...ell.com>,
	vatsa <vatsa@...ibm.com>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sched: properly account IRQ and RT load in SCHED_OTHER
	load balancing


* Peter Zijlstra <peterz@...radead.org> wrote:

> Subject: sched: properly account IRQ and RT load in SCHED_OTHER load balancing
> From: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Date: Thu Aug 14 09:31:20 CEST 2008
> 
> We used to account for RT tasks in SCHED_OTHER load-balancing by giving
> them some phantom weight.
> 
> This is incorrect because there is no saying how much time a RT task 
> will actually consume. Also, it doesn't take IRQ time into account.
> 
> This patch tries to solve this issue by accounting the time spend on 
> both Real-Time tasks and IRQ handling, and using that to 
> proportionally inflate the SCHED_OTHER load.

applied it to tip/sched/devel for more testing.

this bit:

> +void sched_irq_enter(void)
> +{
> +	if (!in_irq()) {
> +		struct rq *rq = this_rq();
> +
> +		update_rq_clock(rq);
> +		rq->irq_stamp = rq->clock;
> +	}

if we do this we might as well use the opportunity to do accurate IRQ 
(and softirq) CPU time accounting. I.e. right now it only drives 
balancing, but isnt fed into the wider IRQ/softirq /proc usage stats.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/