linux-kernel - Re: [3/4] add agp_generic_destroy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080821114952.GE30667@elte.hu>
Date:	Thu, 21 Aug 2008 13:49:52 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Shaohua Li <shaohua.li@...el.com>,
	lkml <linux-kernel@...r.kernel.org>,
	Dave Airlie <airlied@...il.com>,
	Arjan van de Ven <arjan@...radead.org>
Subject: Re: [3/4] add agp_generic_destroy_pages()


* Andrew Morton <akpm@...ux-foundation.org> wrote:

> stylistic nit:
> 
> > +
> > +			for (i = 0; i < curr->page_count; i++) {
> > +				curr->memory[i] = (unsigned long)gart_to_virt(
> > +					curr->memory[i]);
> > +				curr->bridge->driver->agp_destroy_page(
> > +					(void *)curr->memory[i],
> > +					AGP_PAGE_DESTROY_UNMAP);
> > +			}
> > +			for (i = 0; i < curr->page_count; i++) {
> > +				curr->bridge->driver->agp_destroy_page(
> > +					(void *)curr->memory[i],
> > +					AGP_PAGE_DESTROY_FREE);
> > +			}
> 
> Make the above code a standalone function and call it here.
> 
> Then convert all drivers over so their .agp_destroy_pages points at
> that new function.
> 
> Then remove the `if'.

good point.

[ Shaohua, when you fix this, please do it as a delta patch against your 
  current patchset (or against tip/master). Thanks. ]

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/