linux-kernel - Re: apic version warning.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080821143356.GA7214@lenovo>
Date:	Thu, 21 Aug 2008 18:33:56 +0400
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Yinghai Lu <yhlu.kernel@...il.com>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: apic version warning.

[Yinghai Lu - Thu, Aug 21, 2008 at 01:01:19AM -0700]
| after following patch,
| 
| commit 1b313f4a6d7bee7b2c034b3f1e203bc360a71cca
| Author: Cyrill Gorcunov <gorcunov@...il.com>
| Date:   Mon Aug 18 20:45:57 2008 +0400
| 
|     x86: apic - generic_processor_info
| 
|     - use physid_set instead of phys_cpu and physids_or
|     - set phys_cpu_present_map bit AFTER check for allowed
|       number of processors
|     - add checking for APIC valid version in 64bit mode
|       (mostly not needed but added for merging purpose)
|     - add apic_version definition for 64bit mode which
|       is used now
| 
| we are getting warning for acpi path on 64 bit system
| 
| please add #ifdef for that.
| actually, 64 bit doesn't use that apic_version[]
| 
| 
| or using following patch?
| 
| diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
| index 301678b..fc64412 100644
| --- a/arch/x86/kernel/acpi/boot.c
| +++ b/arch/x86/kernel/acpi/boot.c
| @@ -252,10 +252,8 @@ static void __cpuinit acpi_register_lapic(int id,
| u8 enabled)
|                 return;
|         }
| 
| -#ifdef CONFIG_X86_32
|         if (boot_cpu_physical_apicid != -1U)
|                 ver = apic_version[boot_cpu_physical_apicid];
| -#endif
| 
|         generic_processor_info(id, ver);
|  }
| @@ -775,10 +773,8 @@ static void __init
| acpi_register_lapic_address(unsigned long address)
|         set_fixmap_nocache(FIX_APIC_BASE, address);
|         if (boot_cpu_physical_apicid == -1U) {
|                 boot_cpu_physical_apicid  = read_apic_id();
| -#ifdef CONFIG_X86_32
|                 apic_version[boot_cpu_physical_apicid] =
|                          GET_APIC_VERSION(apic_read(APIC_LVR));
| -#endif
|         }
|  }
| 
| 
| YH
| 

Thanks, Yinghai!

		- Cyrill -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/