linux-kernel - Re: [PATCH 06/10] AXFS: axfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 21 Aug 2008 16:54:44 +0200 (CEST)
From:	Sven Wegener <sven.wegener@...aler.net>
To:	Jared Hulbert <jaredeh@...il.com>
cc:	Linux-kernel@...r.kernel.org, linux-embedded@...r.kernel.org,
	linux-mtd <linux-mtd@...ts.infradead.org>,
	Jörn Engel <joern@...fs.org>,
	tim.bird@...SONY.COM, cotte@...ibm.com, nickpiggin@...oo.com.au
Subject: Re: [PATCH 06/10] AXFS: axfs_super.c

On Thu, 21 Aug 2008, Sven Wegener wrote:

> On Wed, 20 Aug 2008, Jared Hulbert wrote:
> 
> > The many different devices AXFS can mount to and the various
> > dual device mounting schemes are supported here.
> > 
> > Signed-off-by: Jared Hulbert <jaredeh@...il.com>
> > ---
> > +static int __init init_axfs_fs(void)
> > +{
> > +	axfs_uncompress_init();
> 
> one more thing, axfs_uncompress_init() can fail
> 
> > +	return register_filesystem(&axfs_fs_type);

And if this fails you leak the memory allocated in axfs_uncompress_init()

> > +}
> > +
> > +static void __exit exit_axfs_fs(void)
> > +{
> > +	axfs_uncompress_exit();
> > +	unregister_filesystem(&axfs_fs_type);
> > +}
> > +
> > +module_init(init_axfs_fs);
> > +module_exit(exit_axfs_fs);
> > +MODULE_LICENSE("GPL");
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/