linux-kernel - Re: Mount ext3 with barrier=1 doesn't send real barrier bio?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <874p5eqa6h.fsf@devron.myhome.or.jp>
Date:	Fri, 22 Aug 2008 07:23:50 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	Eric Sandeen <sandeen@...deen.net>
Cc:	Milan Broz <mbroz@...hat.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Jens Axboe <jens.axboe@...cle.com>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	Ric Wheeler <rwheeler@...hat.com>,
	"MASON\,CHRISTOPHER" <CHRIS.MASON@...cle.com>
Subject: Re: Mount ext3 with barrier=1 doesn't send real barrier bio?

Eric Sandeen <sandeen@...deen.net> writes:

>> --- a/fs/buffer.c
>> +++ b/fs/buffer.c
>> @@ -2926,16 +2926,16 @@ int submit_bh(int rw, struct buffer_head * bh)
>>  	BUG_ON(!buffer_mapped(bh));
>>  	BUG_ON(!bh->b_end_io);
>>  
>> -	if (buffer_ordered(bh) && (rw == WRITE))
>> -		rw = WRITE_BARRIER;
>> -
>>  	/*
>>  	 * Only clear out a write error when rewriting, should this
>>  	 * include WRITE_SYNC as well?
>>  	 */
>> -	if (test_set_buffer_req(bh) && (rw == WRITE || rw == WRITE_BARRIER))
>> +	if (test_set_buffer_req(bh) && rw == WRITE)
>>  		clear_buffer_write_io_error(bh);

This should be ((rw & RW_MASK) == WRITE) too?  Anyway, this seems change
behavior of submit_bh(WRITE_BARRIER) (maybe reiserfs only), it wouldn't
be your intent...

>> +	if (buffer_ordered(bh) && ((rw & RW_MASK) == WRITE))
>> +		rw |= (1 << BIO_RW_BARRIER);
>> +
>>  	/*
>>  	 * from here on down, it's all bio -- do the initial mapping,
>>  	 * submit_bio -> generic_make_request may further map this bio around
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/