linux-kernel - Re: Mount ext3 with barrier=1 doesn't send real barrier bio?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080822075821.GS20055@kernel.dk>
Date:	Fri, 22 Aug 2008 09:58:21 +0200
From:	Jens Axboe <jens.axboe@...cle.com>
To:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
Cc:	Eric Sandeen <sandeen@...deen.net>, Milan Broz <mbroz@...hat.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	Ric Wheeler <rwheeler@...hat.com>,
	"MASON,CHRISTOPHER" <CHRIS.MASON@...cle.com>
Subject: Re: Mount ext3 with barrier=1 doesn't send real barrier bio?

On Fri, Aug 22 2008, OGAWA Hirofumi wrote:
> Jens Axboe <jens.axboe@...cle.com> writes:
> 
> >> This should be ((rw & RW_MASK) == WRITE) too?  Anyway, this seems change
> >> behavior of submit_bh(WRITE_BARRIER) (maybe reiserfs only), it wouldn't
> >> be your intent...
> >
> > Yes, I believe the simpler and more correct fix is:
> >
> > diff --git a/fs/buffer.c b/fs/buffer.c
> > index 38653e3..16b2263 100644
> > --- a/fs/buffer.c
> > +++ b/fs/buffer.c
> > @@ -2926,14 +2926,13 @@ int submit_bh(int rw, struct buffer_head * bh)
> >  	BUG_ON(!buffer_mapped(bh));
> >  	BUG_ON(!bh->b_end_io);
> >  
> > -	if (buffer_ordered(bh) && (rw == WRITE))
> > +	if (buffer_ordered(bh) && (rw & WRITE))
> >  		rw = WRITE_BARRIER;
> 
> I see. But, umm..., this means WRITE_SYNC with barrier was deprecated?
> Or typo?

It was supposed to read rw |= WRITE_BARRIER :-)

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/