lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.44L0.0808221333110.2230-100000@iolanthe.rowland.org>
Date:	Fri, 22 Aug 2008 13:39:50 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Andrey Borzenkov <arvidjaar@...l.ru>
cc:	"Rafael J. Wysocki" <rjw@...k.pl>, <linux-usb@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: 2.6.27-rc4: 90% system time because of khubd, unable to reboot

On Fri, 22 Aug 2008, Andrey Borzenkov wrote:

> > > reverting 38b375d9610e2467cb793a84d17c6f65e44cdb39 fixed it
> > > 
> > 
> > ... that is:
> > 
> > commit 38b375d9610e2467cb793a84d17c6f65e44cdb39
> > Author: Alan Stern <stern@...land.harvard.edu>
> > Date:   Mon Jul 21 09:56:26 2008 -0400
> > 
> >     USB: OHCI: fix system hang caused by earlier patch
> > 
> >     Signed-off-by: Alan Stern <stern@...land.harvard.edu>
> >     Tested by: Andrey Borzenkov <arvidjaar@...l.ru>
> >     Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
> > 
> > so it apparently used to work for you at that time.  What gives?
> > 
> 
> Well, you should not commit a fix without commiting code that has been
> fixed first :)

Actually the code to be fixed _was_ committed first -- but then it was 
reverted before the fix was accepted, so the fix was merged without it.

My advice is not to worry about it.  That code has been sent once again
to Linus -- it's not merged yet but presumably it will be soon.  
Certainly before 2.6.27-rc5 appears.

On the other hand, I still have to wonder how the fix could have caused
your problem without the original patch in place.  The fix itself
should have been totally innocuous.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ