[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <48AE204F.307@cn.fujitsu.com>
Date: Fri, 22 Aug 2008 10:11:27 +0800
From: Li Zefan <lizf@...fujitsu.com>
To: Ranjit Manomohan <ranjitm@...gle.com>
CC: linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
menage@...gle.com, kaber@...sh.net, akpm@...ux-foundation.org
Subject: Re: [PATCH 1/2] Traffic control cgroups subsystem
> +static unsigned int cgroup_tc_classid(struct task_struct *tsk)
> +{
> + unsigned int tc_classid;
> +
> + rcu_read_lock();
> + tc_classid = container_of(task_subsys_state(tsk, tc_subsys_id),
trivial: 2 spaces ^^
> + struct tc_cgroup, css)->classid;
> + rcu_read_unlock();
> + return tc_classid;
> +}
> +
...
> +static int tc_write_u64(struct cgroup *cgrp, struct cftype *cft, u64 val)
> +{
> + struct tc_cgroup *tc = cgroup_to_tc(cgrp);
> +
> + cgroup_lock();
> + if (cgroup_is_removed(cgrp)) {
> + cgroup_unlock();
> + return -ENODEV;
> + }
> +
You may use cgroup_lock_live_group():
if (cgroup_lock_live_group(cgrp0))
return -ENODEV;
> + tc->classid = (unsigned int) (val & 0xffffffff);
> + cgroup_unlock();
> + return 0;
> +}
> +
> +static u64 tc_read_u64(struct cgroup *cont, struct cftype *cft)
'cont', 'cgrp' and 'cgroup' are used, it's better to make it consistent
to use 'cgrp' (or 'cgroup') only.
> +{
> + struct tc_cgroup *tc = cgroup_to_tc(cont);
> + return tc->classid;
> +}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists