linux-kernel - Re: [PATCH] TPM: update char dev BKL pushdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LRH.1.10.0808230858070.24779@tundra.namei.org>
Date:	Sat, 23 Aug 2008 08:58:57 +1000 (EST)
From:	James Morris <jmorris@...ei.org>
To:	"Serge E. Hallyn" <serue@...ibm.com>
cc:	Rajiv Andrade <srajiv@...ux.vnet.ibm.com>,
	linux-kernel@...r.kernel.org, zohar@...ibm.com,
	dvelarde@...ibm.com, safford@...ibm.com
Subject: Re: [PATCH] TPM: update char dev BKL pushdown

On Fri, 22 Aug 2008, Serge E. Hallyn wrote:

> Quoting Rajiv Andrade (srajiv@...ux.vnet.ibm.com):
> > This patch removes the BKL calls from the TPM driver, which
> > were added in the overall misc-char-dev-BKL-pushdown.patch,
> > as they are not needed. Changed num_opens from an int to atomic_t.
> > 
> > Signed-off-by: Mimi Zohar <zohar@...ibm.com>
> > Signed-off-by: Rajiv Andrade <srajiv@...ux.vnet.ibm.com>
> 
> Yes, this patch is good.  
> 
> It would also be good to rename num_opens.  Note that it is always
> either 0 or 1, and indicates whether someone has opened the chip.
> So 'is_open' may make more sense.

And use atomic_set() instead of atomic_inc().



- James
-- 
James Morris
<jmorris@...ei.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/