[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <48AE5BB8.5080701@zytor.com>
Date: Thu, 21 Aug 2008 23:24:56 -0700
From: "H. Peter Anvin" <hpa@...or.com>
To: Andi Kleen <andi@...stfloor.org>
CC: "H. Peter Anvin" <hpa@...nel.org>, Dave Jones <davej@...hat.com>,
Vegard Nossum <vegard.nossum@...il.com>,
the arch/x86 maintainers <x86@...nel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Rusty Russell <rusty@...tcorp.com.au>
Subject: Re: latest -git: WARNING: at arch/x86/kernel/ipi.c:123 send_IPI_mask_bitmask+0xc3/0xe0()
Andi Kleen wrote:
>> You may want to see if this patch fixes the problem; it does *NOT* have
>> the correct error behaviour (some of the intervening layers don't
>> propagate errors), but it should make the fault go away.
>
> The alternative would be to just take out those msr_on_cpu()
> interfaces again. Right now they are useless in the kernel,
> but still cause problems.
>
> They were only added for OpenVZ's vCPUs which they back then
> promised me would hit mainline soon. But that was some time
> ago and there wasn't much progress on this.
>
> -Andi
We still need the equivalent functionality, though. The midlayer
(msr_on_cpu) may be pointless, but that doesn't change the fact that
putting this functionality in the lower layer (smp_call_function_single)
makes more sense.
-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists