linux-kernel - Re: [PATCH 2/9] ide-disk: set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48B0850D.4000105@ru.mvista.com>
Date:	Sun, 24 Aug 2008 01:45:49 +0400
From:	Sergei Shtylyov <sshtylyov@...mvista.com>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/9] ide-disk: set_addressing() fixes

Hello.

Bartlomiej Zolnierkiewicz wrote:

> * Return -EIO if arg > 0 and LBA48 is unsupported.
>
> * No need to reset ->addressing.
>
> * Make ->addressing a single bit flag.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
>   
[...]
> Index: b/include/linux/ide.h
> ===================================================================
> --- a/include/linux/ide.h
> +++ b/include/linux/ide.h
> @@ -507,7 +507,7 @@ struct ide_drive_s {
>  	unsigned sleeping	: 1;	/* 1=sleeping & sleep field valid */
>  	unsigned post_reset	: 1;
>  	unsigned udma33_warned	: 1;
> -	unsigned addressing	: 2;	/* 0=28-bit, 1=48-bit, 2=48-bit doing 28-bit */
> +	unsigned addressing	: 1;	/* 0=28-bit, 1=48-bit */
>  	unsigned wcache		: 1;	/* status of write cache */
>  	unsigned nowerr		: 1;	/* used for ignoring ATA_DF */
>   

   Don't you want to get rid of things like:

        u8 lba48 = (drive->addressing == 1) ? 1 : 0;

MBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/