lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sat, 23 Aug 2008 13:03:43 +0200
From:	Marcel Holtmann <holtmann@...ux.intel.com>
To:	Jim Meyering <meyering@...hat.com>
Cc:	linux-kernel@...r.kernel.org, Sujith.Manoharan@...eros.com,
	linville@...driver.com
Subject: Re: [PATCH] ath9k: remove useless if-before-kfree; correct
	misleading indentation

Hi Jim,

> >> Alternatively, you could remove the nowadays-useless
> >> "if-before-kfree" test and leave the sometimes-redundant
> >> assignment as-is: unconditional.
> >
> > actually the later one is preferred. Just remove the NULL check.
> 
> I prefer it, too, but the indentation suggested that
> adding braces would match the author's intent.
> 
> In case anyone is interested, I have been maintaining a patch
> that removes *all* useless if-before-kfree tests.  I have not
> posted it because such changes have a reputation for provoking
> flames on this list, but now you've provoked me ;-)
> 
>     http://meyering.net/code/remove-useless-if-before-kfree.patch
>      74 files changed, 127 insertions(+), 250 deletions(-)

I am all for this patch.

Even the Glibc free() function will do an "if-before-free" :)

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists