[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20080823021410.GB21403@suse.de>
Date: Fri, 22 Aug 2008 19:14:10 -0700
From: Greg KH <gregkh@...e.de>
To: Ville Syrjälä <syrjala@....fi>,
linux-kernel@...r.kernel.org, Ingo Oeser <ioe-lkml@...eria.de>,
Kay Sievers <kay.sievers@...y.org>
Subject: Re: [PATCH 01/15] kobject: Replace ALL occurrences of '/' with '!'
instead of only the first one.
On Fri, Aug 22, 2008 at 03:41:53PM +0300, Ville Syrjälä wrote:
> On Thu, Aug 21, 2008 at 10:32:49AM -0700, Greg Kroah-Hartman wrote:
> > From: Ingo Oeser <ioe-lkml@...eria.de>
> >
> > A recent patch from Kay Sievers <kay.sievers@...y.org>
> > replaced the first occurrence of '/' with '!' as needed for block devices.
> >
> > Now do some cheap defensive coding and replace all of them to avoid future
> > issues in this area.
> >
> > Signed-off-by: Ingo Oeser <ioe-lkml@...eria.de>
> > Cc: Kay Sievers <kay.sievers@...y.org>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
> > ---
> > lib/kobject.c | 3 +--
> > 1 files changed, 1 insertions(+), 2 deletions(-)
> >
> > diff --git a/lib/kobject.c b/lib/kobject.c
> > index bd732ff..fbf0ae2 100644
> > --- a/lib/kobject.c
> > +++ b/lib/kobject.c
> > @@ -223,8 +223,7 @@ static int kobject_set_name_vargs(struct kobject *kobj, const char *fmt,
> > return -ENOMEM;
> >
> > /* ewww... some of these buggers have '/' in the name ... */
> > - s = strchr(kobj->name, '/');
> > - if (s)
> > + while ((s = strchr(kobj->name, '/')))
> > s[0] = '!';
>
> That's somewhat inefficient. How about this?
>
> s = kobj->name;
> while ((s = strchr(s, '/')))
> *s++ = '!';
Sure, but does it really matter?
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists