linux-kernel - Re: [RFC] readdir mess

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.10.0808241017580.3363@nehalem.linux-foundation.org>
Date:	Sun, 24 Aug 2008 10:20:52 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Al Viro <viro@...IV.linux.org.uk>
cc:	Jan Harkes <jaharkes@...cmu.edu>, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC] readdir mess



On Sun, 24 Aug 2008, Al Viro wrote:
> 
> One obvious note: that'll break old_readdir() on coda.  There you need to
> change the existing check (you need to check buf.result, then ignore error
> unless buf.result ended up 0).

Hmm? old_readdir() was the only one that I didn't change, because it 
didn't need changing. It already ignores the return value of 
"vfs_readdir()" entirely if it is positive or zero, and takes it from 
buf.result.

So old_readdir() literally doesn't care at all (and never has) whether a 
->readdir() function returns zero or a positive number. So changing coda 
readdir() it to return zero _instead_ of a positive number makes 
absolutely zero difference: old_readdir() will do the same thing 
regardless.

What am I missing?

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/