[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c62985530808250659w5b2a2f83u689987969a4cb53d@mail.gmail.com>
Date: Mon, 25 Aug 2008 14:59:41 +0100
From: "Frédéric Weisbecker" <fweisbec@...il.com>
To: "Ingo Molnar" <mingo@...e.hu>
Cc: "Steven Rostedt" <rostedt@...dmis.org>,
"Linux Kernel" <linux-kernel@...r.kernel.org>
Subject: Re: [Patch] Tracing/ftrace: Adds a marker to allow user comments
2008/8/25 Ingo Molnar <mingo@...e.hu>:
>
> * Frédéric Weisbecker <fweisbec@...il.com> wrote:
>
>> The documentation of mmiotrace describes an unimplemented feature
>> which allows the user to write any comments on his trace by writing on
>> a tracing/marker file. Here is an implementation of this idea.
>>
>> It applies on last version of tip tree.
>
> hmm ... have you looked at the (recently implemented) ftrace_printk()
> facility?
>
> Ingo
>
Yes but I didn't want to use ftrace_printk() because it needs the "ip"
parameter. User messages doesn't need this. But I reuse a part of the
code of ftrace_printk and I splitted ftrace_printk() in two parts for
this purpose: __ftrace_printk() and trace_print().
I also reused the print_entry but with a new TRACE_MARK type to make
the difference when it is time to send the entry to the pipe because
user messages don't use ip.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists