linux-kernel - Re: [PATCH] devcgroup: use kmemdup()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080825164326.GB13583@us.ibm.com>
Date:	Mon, 25 Aug 2008 11:43:26 -0500
From:	"Serge E. Hallyn" <serue@...ibm.com>
To:	Li Zefan <lizf@...fujitsu.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Paul Menage <menage@...gle.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux Containers <containers@...ts.linux-foundation.org>
Subject: Re: [PATCH] devcgroup: use kmemdup()

Quoting Li Zefan (lizf@...fujitsu.com):
> This saves 40 bytes on my x86_32 box.
> 
> Signed-off-by: Li Zefan <lizf@...fujitsu.com>

Acked-by: Serge Hallyn <serue@...ibm.com>

> ---
>  security/device_cgroup.c |    9 ++-------
>  1 files changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/security/device_cgroup.c b/security/device_cgroup.c
> index 46f2397..9c625f6 100644
> --- a/security/device_cgroup.c
> +++ b/security/device_cgroup.c
> @@ -84,13 +84,9 @@ static int dev_whitelist_copy(struct list_head *dest, struct list_head *orig)
>  	struct dev_whitelist_item *wh, *tmp, *new;
> 
>  	list_for_each_entry(wh, orig, list) {
> -		new = kmalloc(sizeof(*wh), GFP_KERNEL);
> +		new = kmemdup(wh, sizeof(*wh), GFP_KERNEL);
>  		if (!new)
>  			goto free_and_exit;
> -		new->major = wh->major;
> -		new->minor = wh->minor;
> -		new->type = wh->type;
> -		new->access = wh->access;
>  		list_add_tail(&new->list, dest);
>  	}
> 
> @@ -114,11 +110,10 @@ static int dev_whitelist_add(struct dev_cgroup *dev_cgroup,
>  {
>  	struct dev_whitelist_item *whcopy, *walk;
> 
> -	whcopy = kmalloc(sizeof(*whcopy), GFP_KERNEL);
> +	whcopy = kmemdup(wh, sizeof(*wh), GFP_KERNEL);
>  	if (!whcopy)
>  		return -ENOMEM;
> 
> -	memcpy(whcopy, wh, sizeof(*whcopy));
>  	spin_lock(&dev_cgroup->lock);
>  	list_for_each_entry(walk, &dev_cgroup->whitelist, list) {
>  		if (walk->type != wh->type)
> -- 
> 1.5.4.rc3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/