linux-kernel - Re: [PATCH] x86: let 64 bit to use 32 bit calibrate_apic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080825074704.GA20698@elte.hu>
Date:	Mon, 25 Aug 2008 09:47:04 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Yinghai Lu <yhlu.kernel@...il.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: let 64 bit to use 32 bit calibrate_apic_clock


* Yinghai Lu <yhlu.kernel@...il.com> wrote:

> Signed-of-by: Yinghai Lu <yhlu.kernel@...il.com>

applied to tip/irq/sparseirq - thanks Yinghai.

btw., why was this bit needed:

> @@ -659,6 +575,7 @@ static int __init calibrate_APIC_clock(v
>  	delta = lapic_cal_t1 - lapic_cal_t2;
>  	apic_printk(APIC_VERBOSE, "... lapic delta = %ld\n", delta);
>  
> +#ifdef CONFIG_X86_PM_TIMER
>  	/* Check, if the PM timer is available */
>  	deltapm = lapic_cal_pm2 - lapic_cal_pm1;
>  	apic_printk(APIC_VERBOSE, "... PM timer delta = %ld\n", deltapm);
> @@ -687,6 +604,7 @@ static int __init calibrate_APIC_clock(v
>  		}
>  		pm_referenced = 1;
>  	}
> +#endif

wouldnt this be a (small) fix for the pre-unification 32-bit side as 
well, which we should put into tip/x86/urgent as well?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/