linux-kernel - Re: [PATCH] ftrace: objcopy version test for local symbols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080826115113.806cfe23.sfr@canb.auug.org.au>
Date:	Tue, 26 Aug 2008 11:51:13 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Steven Rostedt <rostedt@...dmis.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>, linux-next@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ftrace: objcopy version test for local symbols

Hi Ingo, Steve,

On Tue, 26 Aug 2008 09:46:27 +1000 Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>
> On Mon, 25 Aug 2008 21:01:03 +0200 Ingo Molnar <mingo@...e.hu> wrote:
> >
> > applied to tip/tracing/ftrace, also have integrated it into 
> > auto-ftrace-next. (without much testing - i hope it goes well)
> 
> Looks ok at a first glance, but it may spam my build logs a bit ...
> Anyway, we will see.

I was right, it produces way to many messages :-(

I applied the following patch for now.  It would be nice if this check
could be done once per build and warned about once as well.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

>From 54bc3035c76a242d14df554966110e5964b3eac3 Mon Sep 17 00:00:00 2001
From: Stephen Rothwell <sfr@...b.auug.org.au>
Date: Tue, 26 Aug 2008 11:45:01 +1000
Subject: [PATCH] ftrace: silence overly verbose warning

Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
---
 scripts/recordmcount.pl |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl
index ee9e126..ef0c6db 100755
--- a/scripts/recordmcount.pl
+++ b/scripts/recordmcount.pl
@@ -262,12 +262,12 @@ sub update_funcs
 
 	# only use locals if objcopy supports globalize-symbols
 	if (!$use_locals) {
-	    print STDERR
-		"$inputfile: WARNING: referencing local function " .
-		"$ref_func for mcount\n" .
-		"\tConsider upgrading objcopy to support the globalize-" .
-		"symbols option.\n"
-		if (!$local_warn_once++);
+#	    print STDERR
+#		"$inputfile: WARNING: referencing local function " .
+#		"$ref_func for mcount\n" .
+#		"\tConsider upgrading objcopy to support the globalize-" .
+#		"symbols option.\n"
+#		if (!$local_warn_once++);
 	    return;
 	}
 	$convert{$ref_func} = 1;
-- 
1.5.6.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/