linux-kernel - Re: [rtc-linux] Re: [RFC] Driver for Real Time Clock chip ST M41T65

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48B4159A.9070907@harris.com>
Date:	Tue, 26 Aug 2008 10:39:22 -0400
From:	"Steven A. Falco" <sfalco@...ris.com>
To:	Alessandro Zummo <alessandro.zummo@...ertech.it>
CC:	rtc-linux@...glegroups.com, will.newton@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [rtc-linux] Re: [RFC] Driver for Real Time Clock chip ST M41T65

Alessandro Zummo wrote:
> On Tue, 26 Aug 2008 15:00:03 +0100
> "Will Newton" <will.newton@...il.com> wrote:
> 
> 
>>>> On Mon, Aug 25, 2008 at 6:27 PM, Steven A. Falco <sfalco@...ris.com> wrote:
>>>>> I will be using a Real Time Clock chip, ST M41T65, on a new embedded system.
>>>>> The chip is quite similar to the M41T8x family, which already has driver
>>>>> rtc-m41t80.c.
>>>>>
>>>>> Would it be more acceptible to generalize rtc-m41t80.c (perhaps renaming it to
>>>>> rtc-m41txx.c) or would it be better to create a new rtc-m41t6x.c?
>>> Thanks for the feedback.  Here is a respin which addresses your comments.
>>>
>>> I'd also like to know if I should submit a new driver or mod the existing
>>> one.  If I mod the existing one, should it be renamed, should I update the
>>> Kconfig, existing defconfigs, etc?
> 
>  Given the small amount of changes, I would use the existing driver without
>  renaming it.
> 

Sounds good.  Please let me know if there are other changes needed to make this
patch acceptable for inclusion into the mainline.

	Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/