[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20080826165536.61c25a67.akpm@linux-foundation.org>
Date: Tue, 26 Aug 2008 16:55:36 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Bruce Leonard <brucle@...thlink.net>
Cc: linux-kernel@...r.kernel.org,
David Woodhouse <dwmw2@...radead.org>,
linux-mtd@...ts.infradead.org
Subject: Re: [PATCH 2/2][MTD] Add support for > 2GiB MTD devices
On Thu, 21 Aug 2008 19:00:55 -0700 (GMT-07:00)
Bruce Leonard <brucle@...thlink.net> wrote:
> --- a/include/mtd/mtd-abi.h
> +++ b/include/mtd/mtd-abi.h
> @@ -6,7 +6,7 @@
> #define __MTD_ABI_H__
>
> struct erase_info_user {
> - uint32_t start;
> + uint64_t start;
> uint32_t length;
> };
>
> @@ -50,7 +50,7 @@ struct mtd_oob_buf {
> struct mtd_info_user {
> uint8_t type;
> uint32_t flags;
> - uint32_t size; // Total size of the MTD
> + uint64_t size; // Total size of the MTD
> uint32_t erasesize;
> uint32_t writesize;
> uint32_t oobsize; // Amount of OOB data per block (e.g. 16)
This changes the kernel<->userspace ABI and is hence a big no-no. I
assume that this change will cause old userspace to malfunction on new
kernels, and vice versa.
Supporting >2Gb MTD devices sounds useful (I'm surprised that we don't
already do so).
Please cc linux-mtd@...ts.infradead.org (at least) on MTD-related
patches, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists