linux-kernel - [PATCH] netfilter: xt_time gives a wrong monthday in a leap year

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <c0ff893e0808251803tee7f145i6a5aa9f79d943dec@mail.gmail.com>
Date:	Tue, 26 Aug 2008 09:03:43 +0800
From:	"luo kaih" <kaih.luo@...il.com>
To:	netfilter-devel@...r.kernel.org
Cc:	trivial@...nel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] netfilter: xt_time gives a wrong monthday in a leap year

the function localtime_3 in xt_time.c  gives a wrong monthday in a
leap year after 28th 2 . calculating monthday should use the array
days_since_leapyear[] not
days_since_year[]  in a leap year .
Signed-off-by: Kaihui Luo <kaih.luo@...il.com>
---
--- linux-2.6.26/net/netfilter/xt_time.c.orig   2008-08-25
11:59:46.000000000 +0800
+++ linux-2.6.26/net/netfilter/xt_time.c        2008-08-25
12:16:12.000000000 +0800
@@ -136,17 +136,19 @@ static void localtime_3(struct xtm *r, t
        * from w repeatedly while counting.)
        */
       if (is_leap(year)) {
+               /* use days_since_leapyear[] in a leap year */
               for (i = ARRAY_SIZE(days_since_leapyear) - 1;
-                   i > 0 && days_since_year[i] > w; --i)
+                   i > 0 && days_since_leapyear[i] > w; --i)
                       /* just loop */;
+               r->monthday = w - days_since_leapyear[i] + 1;
       } else {
               for (i = ARRAY_SIZE(days_since_year) - 1;
                   i > 0 && days_since_year[i] > w; --i)
                       /* just loop */;
+               r->monthday = w - days_since_year[i] + 1;
       }

       r->month    = i + 1;
-       r->monthday = w - days_since_year[i] + 1;
       return;
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/