linux-kernel - Re: [PATCH] VIDEO_SH_MOBILE_CEU should depend on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aec7e5c30808270241x12bac614lc573293ce84d608e@mail.gmail.com>
Date:	Wed, 27 Aug 2008 18:41:03 +0900
From:	"Magnus Damm" <magnus.damm@...il.com>
To:	"Geert Uytterhoeven" <geert@...ux-m68k.org>
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Mauro Carvalho Chehab" <mchehab@...radead.org>,
	"Paul Mundt" <lethal@...ux-sh.org>, video4linux-list@...hat.com,
	"Linux Kernel Development" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] VIDEO_SH_MOBILE_CEU should depend on HAS_DMA (was: Re: m68k allmodconfig)

On Wed, Aug 27, 2008 at 4:37 AM, Geert Uytterhoeven
<geert@...ux-m68k.org> wrote:
>        Hi Andrew,
>
> On Thu, 14 Aug 2008, Andrew Morton wrote:
>> ERROR: "dma_alloc_coherent" [drivers/media/video/videobuf-dma-contig.ko] undefined!
>> ERROR: "dma_sync_single_for_cpu" [drivers/media/video/videobuf-dma-contig.ko] undefined!
>> ERROR: "dma_free_coherent" [drivers/media/video/videobuf-dma-contig.ko] undefined!
>
> M68k allmodconfig still selects Sun-3, which sets NO_DMA.
> I guess you're also seeing this on the other NO_DMA platforms (h8300, m32r,
> s390, and PCI-less SPARC)?
>
> Below is a patch.
>
> Shouldn't it also (or instead) depend on SUPERH or some SuperH platform?
> Or is this not done to have more compile-coverage?
>
> Subject: [PATCH] VIDEO_SH_MOBILE_CEU should depend on HAS_DMA
>
> commit 0d3244d6439c8c31d2a29efd587c7aca9042c8aa ("V4L/DVB (8342):
> sh_mobile_ceu_camera: Add SuperH Mobile CEU driver V3") introduced
> VIDEO_SH_MOBILE_CEU, which selects VIDEOBUF_DMA_CONTIG. This circumvents the
> dependency on HAS_DMA of VIDEOBUF_DMA_CONTIG.
>
> Add a dependency on HAS_DMA to VIDEO_SH_MOBILE_CEU to fix this.

Thank you!

> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Acked-by: Magnus Damm <damm@...l.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/