linux-kernel - Re: [PATCH 3/4] pid_ns: de_thread: kill the now unneeded ->child

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080827023142.GB2320@us.ibm.com>
Date:	Tue, 26 Aug 2008 21:31:42 -0500
From:	"Serge E. Hallyn" <serue@...ibm.com>
To:	Oleg Nesterov <oleg@...sign.ru>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Pavel Emelyanov <xemul@...nvz.org>,
	Robert Rex <robert.rex@...sol.com>,
	Roland McGrath <roland@...hat.com>,
	Sukadev Bhattiprolu <sukadev@...ibm.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] pid_ns: de_thread: kill the now unneeded
	->child_reaper change

Quoting Oleg Nesterov (oleg@...sign.ru):
> de_thread() checks if the old leader was the ->child_reaper, this is not
> possible any longer. With the previous patch ->group_leader itself will
> change ->child_reaper on exit.

Neat.

> >From now find_new_reaper() is the only function (apart from initialization)
> which plays with ->child_reaper.
> 
> Signed-off-by: Oleg Nesterov <oleg@...sign.ru>

Acked-by: Serge Hallyn <serue@...ibm.com>

> 
> --- 2.6.27-rc4/fs/exec.c~3_EXEC	2008-07-30 13:12:47.000000000 +0400
> +++ 2.6.27-rc4/fs/exec.c	2008-08-24 19:20:05.000000000 +0400
> @@ -825,8 +825,6 @@ static int de_thread(struct task_struct 
>  			schedule();
>  		}
> 
> -		if (unlikely(task_child_reaper(tsk) == leader))
> -			task_active_pid_ns(tsk)->child_reaper = tsk;
>  		/*
>  		 * The only record we have of the real-time age of a
>  		 * process, regardless of execs it's done, is start_time.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/